working solution #1204
Open
working solution #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moroz-Dmytro
suggested changes
Dec 5, 2024
src/App.tsx
Outdated
| > | ||
| Something went wrong! | ||
| </div> | ||
| const isShowPostsBlock = currentUser && !isPostsError && !isPostsLoading; |
There was a problem hiding this comment.
Suggested change
| const isShowPostsBlock = currentUser && !isPostsError && !isPostsLoading; | |
| const isPostsBlockShown = currentUser && !isPostsError && !isPostsLoading; |
src/App.tsx
Outdated
| <UserSelector /> | ||
| </div> | ||
| export const App: React.FC = () => { | ||
| const [isShowForm, setIsShowForm] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [isShowForm, setIsShowForm] = useState(false); | |
| const [isFormShown, setIsFormShown] = useState(false); |
src/App.tsx
Outdated
| )} | ||
|
|
||
| {isShowPostsBlock && | ||
| (posts.length === 0 ? ( |
There was a problem hiding this comment.
Suggested change
| (posts.length === 0 ? ( | |
| (!posts.length ? ( |
src/components/PostDetails.tsx
Outdated
| delete button | ||
| </button> | ||
| </div> | ||
| {isShowCommentsBlock && comments.length === 0 && ( |
src/components/PostDetails.tsx
Outdated
| {'Multi\nline\ncomment'} | ||
| </div> | ||
| </article> | ||
| {isShowCommentsBlock && comments.length !== 0 && ( |
src/hooks/useComments.ts
Outdated
Comment on lines
33
to
34
| try { | ||
| try { |
src/hooks/useComments.ts
Outdated
Comment on lines
49
to
50
| try { | ||
| try { |
src/hooks/usePosts.ts
Outdated
Comment on lines
15
to
16
| try { | ||
| try { |
src/hooks/useUsers.ts
Outdated
Comment on lines
16
to
17
| } finally { | ||
| } |
src/hooks/useUsers.ts
Outdated
|
|
||
| setUsers(usersFromServer); | ||
| } catch { | ||
| throw new Error('Unable to load users'); |
There was a problem hiding this comment.
You should not throw an error inside catch
|
I couldn’t pass two tests: ‘should not request posts from API’ and ‘should not request comments from API’, even though the application is working as intended. The other tests was passed ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK